----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3234/#review10901 -----------------------------------------------------------
Finished with page 1, though I had to look ahead to page 3 to be sure you weren't leaking a ton of references when copying formats onto frames :) /team/file/media_formats-impl/apps/app_meetme.c <https://reviewboard.asterisk.org/r/3234/#comment20521> This doesn't seem to be doing the same thing as it used to. It used to set up a translation path from SLIN to 1 << idx. Now it's setting up a translation path from SLIN to the channel's raw write format. Why is this change being made? - Mark Michelson On Feb. 16, 2014, 3:56 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3234/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2014, 3:56 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This movies basic channel drivers and applications over to the new media > formats API. > > > Diffs > ----- > > /team/file/media_formats-impl/pbx/pbx_spool.c 408257 > /team/file/media_formats-impl/main/frame.c 408257 > /team/file/media_formats-impl/main/format_ng.c 408257 > /team/file/media_formats-impl/main/format_cap_ng.c 408257 > /team/file/media_formats-impl/main/format_cap.c 408257 > /team/file/media_formats-impl/main/format_cache.c 408257 > /team/file/media_formats-impl/main/format.c 408257 > /team/file/media_formats-impl/main/codec.c 408257 > /team/file/media_formats-impl/main/channel_internal_api.c 408257 > /team/file/media_formats-impl/main/channel.c 408257 > /team/file/media_formats-impl/include/asterisk/translate.h 408257 > /team/file/media_formats-impl/include/asterisk/slin.h 408257 > /team/file/media_formats-impl/include/asterisk/rtp_engine.h 408257 > /team/file/media_formats-impl/include/asterisk/mod_format.h 408257 > /team/file/media_formats-impl/include/asterisk/frame.h 408257 > /team/file/media_formats-impl/include/asterisk/format_ng.h 408257 > /team/file/media_formats-impl/include/asterisk/format_cap_ng.h 408257 > /team/file/media_formats-impl/include/asterisk/format_cap.h 408257 > /team/file/media_formats-impl/include/asterisk/format_cache.h 408257 > /team/file/media_formats-impl/include/asterisk/format.h 408257 > /team/file/media_formats-impl/include/asterisk/data.h 408257 > /team/file/media_formats-impl/include/asterisk/codec.h 408257 > /team/file/media_formats-impl/include/asterisk/channel.h 408257 > /team/file/media_formats-impl/codecs/ex_alaw.h 408257 > /team/file/media_formats-impl/codecs/ex_adpcm.h 408257 > /team/file/media_formats-impl/codecs/codec_adpcm.c 408257 > /team/file/media_formats-impl/channels/chan_oss.c 408257 > /team/file/media_formats-impl/channels/chan_bridge_media.c 408257 > /team/file/media_formats-impl/channels/chan_alsa.c 408257 > /team/file/media_formats-impl/apps/confbridge/conf_chan_record.c 408257 > /team/file/media_formats-impl/apps/app_waitforsilence.c 408257 > /team/file/media_formats-impl/apps/app_voicemail.c 408257 > /team/file/media_formats-impl/apps/app_test.c 408257 > /team/file/media_formats-impl/apps/app_talkdetect.c 408257 > /team/file/media_formats-impl/apps/app_speech_utils.c 408257 > /team/file/media_formats-impl/apps/app_sms.c 408257 > /team/file/media_formats-impl/apps/app_record.c 408257 > /team/file/media_formats-impl/apps/app_originate.c 408257 > /team/file/media_formats-impl/apps/app_nbscat.c 408257 > /team/file/media_formats-impl/apps/app_mp3.c 408257 > /team/file/media_formats-impl/apps/app_mixmonitor.c 408257 > /team/file/media_formats-impl/apps/app_milliwatt.c 408257 > /team/file/media_formats-impl/apps/app_meetme.c 408257 > /team/file/media_formats-impl/apps/app_ices.c 408257 > /team/file/media_formats-impl/apps/app_festival.c 408257 > /team/file/media_formats-impl/apps/app_dumpchan.c 408257 > /team/file/media_formats-impl/apps/app_dictate.c 408257 > /team/file/media_formats-impl/apps/app_dahdibarge.c 408257 > /team/file/media_formats-impl/apps/app_confbridge.c 408257 > /team/file/media_formats-impl/apps/app_chanspy.c 408257 > /team/file/media_formats-impl/apps/app_amd.c 408257 > /team/file/media_formats-impl/apps/app_alarmreceiver.c 408257 > /team/file/media_formats-impl/apps/app_agent_pool.c 408257 > > Diff: https://reviewboard.asterisk.org/r/3234/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
