----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3264/#review10944 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On Feb. 24, 2014, 11:09 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3264/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 11:09 p.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Bugs: ASTERISK-23350 > https://issues.asterisk.org/jira/browse/ASTERISK-23350 > > > Repository: testsuite > > > Description > ------- > > tests/manager/acl-login assumes that an AMI connection to 127.0.0.2 will be > sent from 127.0.0.2. On some systems all connections to 127.0.0.x are made > from 127.0.0.1 by default. > > This change includes a fallback of not passing the bindAddress, since this > parameter was just added to AMIFactory.login. > > > Diffs > ----- > > /asterisk/trunk/tests/manager/acl-login/run-test 4730 > > Diff: https://reviewboard.asterisk.org/r/3264/diff/ > > > Testing > ------- > > Tested with AMIFactory.login that doesn't accept bindAddress and with updated > starpy that accepts it. With old starpy the test failed due to all > connections being from 127.0.0.1. With updated starpy the test passed. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
