-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3249/
-----------------------------------------------------------
(Updated Feb. 28, 2014, 1:39 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Bugs: ASTERISK-23349
https://issues.asterisk.org/jira/browse/ASTERISK-23349
Repository: testsuite
Description
-------
AMILoginTest.on_failure should accept 2 parameters (self, reason). Both
manager/danger tests declare the procedure with only a single parameter. This
causes a python backtrace when an AMI error tries calling on_failure.
Diffs
-----
/asterisk/trunk/tests/manager/danger/safe/run-test 4730
/asterisk/trunk/tests/manager/danger/dangerous/run-test 4730
Diff: https://reviewboard.asterisk.org/r/3249/diff/
Testing
-------
Original failure found with old version of starpy that mishandled channel None
for AMI getVar. This change caused the correct error "Failed to execute
GetVar" instead of a python backtrace.
Thanks,
Corey Farrell
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
