> On March 14, 2014, 4:03 p.m., zvision wrote: > > If I have a similar fix for branch 12, should I upload a diff here or > > should I create a new review request? > > Matt Jordan wrote: > Is the patch the same? > > If the patches are the same - minus any syntax changes that would occur > during a merge - then the person doing the committing can make the necessary > adjustments. If you'd like to leave a patch on the issue as guidance, that's > nice. > > If there are semantic differences, then it may be worthwhile posting a > separate review.
I've uploaded a diff for branch 12, but it replaced the one for branch 11. I should probably add it as a file, am I correct? Is it possible to discard the last diff? - zvision ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3335/#review11203 ----------------------------------------------------------- On March 14, 2014, 4:32 p.m., zvision wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3335/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 4:32 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23459 > https://issues.asterisk.org/jira/browse/ASTERISK-23459 > > > Repository: Asterisk > > > Description > ------- > > This patch fixes setting nullable integer columns to NULL instead of an empty > string, which fails for PostgreSQL, for example. > The current code is supposed to do so, but the check is broken. The patch > also allows the first column in the list to be a nullable integer. > Also, the check for existence of a mandatory column checked for the first > column in the list instead of the key field lookup column. > > > Diffs > ----- > > http://svn.asterisk.org/svn/asterisk/branches/12/res/res_config_odbc.c > 410554 > > Diff: https://reviewboard.asterisk.org/r/3335/diff/ > > > Testing > ------- > > Tested by me. Use case scenario: Asterisk + res_odbc + PostgreSQL backend, > SIP realtime peers + regs. > When a 'port' column in SIP regs (I assume this also applies when using > sippeers only) is a nullable integer, > Asterisk tries to write an empty string here during SIP endpoint > deregistration. > > > Thanks, > > zvision > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
