> On March 18, 2014, 11:22 a.m., Matt Jordan wrote: > > /team/group/media_formats-reviewed/include/asterisk/frame.h, lines 131-141 > > <https://reviewboard.asterisk.org/r/3319/diff/1/?file=55694#file55694line131> > > > > This feels a bit odd. ast_frame_video is basically just the same as > > ast_format, just with an rtp_marker_bit - which doesn't feel like its > > uniquely a property of ast_frame_video. > > > > Should whether or not the rtp_marker_bit is set be a property of > > something else somewhere? > > Joshua Colp wrote: > It's supposed to signal end of a complete video frame (since it may cross > multiple packets). Renaming it should probably be done but I'm not sure where > else I'd put it.
I'd go with rename then. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/#review11278 ----------------------------------------------------------- On March 8, 2014, 11:36 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3319/ > ----------------------------------------------------------- > > (Updated March 8, 2014, 11:36 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Through implementing things some additional functionality needed to be > added/tweaked. This does so. > > > Diffs > ----- > > /team/group/media_formats-reviewed/main/format_cap.c 410188 > /team/group/media_formats-reviewed/main/format.c 410186 > /team/group/media_formats-reviewed/main/codec.c 410188 > /team/group/media_formats-reviewed/include/asterisk/frame.h 410188 > /team/group/media_formats-reviewed/include/asterisk/format_cap.h 410188 > /team/group/media_formats-reviewed/include/asterisk/format_cache.h 410189 > /team/group/media_formats-reviewed/include/asterisk/format.h 410186 > /team/group/media_formats-reviewed/include/asterisk/codec.h 410188 > /team/group/media_formats-reviewed/include/asterisk/callerid.h 409286 > > Diff: https://reviewboard.asterisk.org/r/3319/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
