----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3329/#review11294 -----------------------------------------------------------
./asterisk/trunk/tests/agi/exit_status/run-test <https://reviewboard.asterisk.org/r/3329/#comment20934> Invert this test so you can return early and then drop the indentation of the remainder of the function. ./asterisk/trunk/tests/agi/exit_status/run-test <https://reviewboard.asterisk.org/r/3329/#comment20935> Invert these tests so you can return early and then drop the indentation of the remainder of the function. - opticron On March 14, 2014, 9:43 a.m., Benjamin Keith Ford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3329/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 9:43 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-19167 > https://issues.asterisk.org/jira/browse/ASTERISK-19167 > > > Repository: testsuite > > > Description > ------- > > Notes: > - Is a sub-task of ASTERISK-19167 > - Ignore userA directory; will be removed from repository > > This test runs through a few different AGI scripts to verify that AGISTATUS > returns the correct values: > 1. Attempts to run an AGI script that does not exist. AGISTATUS returns > NOTFOUND. > 2. Attempts to run an AGI script that has an invalid path. AGISTATUS returns > FAILURE. > 3. Attempts to run an AGI script that has a non-executable interpreter. > AGISTATUS returns FAILURE. > 4. Attempts to run an AGI script that is non-executable. AGISTATUS returns > FAILURE. > 5. Runs an AGI script that will be hung up on while waiting for a command. > AGISTATUS returns HANGUP. > 6. Runs an AGI script that will be hung up on while executing a command. > AGISTATUS returns HANGUP. > 7. Runs an AGI script that exits normally. AGISTATUS returns SUCCESS. > > > Diffs > ----- > > ./asterisk/trunk/tests/agi/exit_status/waiting.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/test-config.yaml 4749 > ./asterisk/trunk/tests/agi/exit_status/run-test 4749 > ./asterisk/trunk/tests/agi/exit_status/executing.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/donothing.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/badinterpreter3.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/badinterpreter2.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/badinterpreter.agi PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3329/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Keith Ford > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
