-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3368/
-----------------------------------------------------------
(Updated March 25, 2014, 10:50 a.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 411088
Bugs: ASTERISK-22079
https://issues.asterisk.org/jira/browse/ASTERISK-22079
Repository: Asterisk
Description
-------
As requested, here is a workaround (not a fix) for the SIP SEGV caused by a
scheduler race condition.
If a provisional keepalive is simultaneously rescheduled/cancelled, and
executed by 2 parallel threads, then a scheduled event can be leaked.
The correct fix will probably involve a re-factoring of the scheduler so that a
scheduled-job-reference is held by the owner, rather than just a
scheduled-job-id as at present. That is outside the scope of this fix, which
simply re-checks that the scheduler-id is unchanged after the lock has been
obtained when running the scheduled job.
There is probably scope for doing this is several other scheduled function
calls.
Diffs
-----
/tags/1.8.25.0/channels/chan_sip.c 408955
Diff: https://reviewboard.asterisk.org/r/3368/diff/
Testing
-------
Run on live server for several weeks.
Tested on load-test environment with following dialplan, which previously
caused a crash in < 30 mins at 1 call per second.
exten => 900,1,NoOp(Crash Generator)
same => n,Ringing
same => n,Wait(60)
same => n,Progress
same => n,Hangup
Thanks,
one47
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
