----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3313/#review11407 -----------------------------------------------------------
./asterisk/trunk/lib/python/asterisk/pluggable_modules.py <https://reviewboard.asterisk.org/r/3313/#comment21057> If 'trigger' is required and it always has to be set to 'ami_connect' there is probably no reason for it to be configurable and can be removed as such. ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py <https://reviewboard.asterisk.org/r/3313/#comment21058> I'd probably add some text to go along with the debug statement, or just remove it. ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py <https://reviewboard.asterisk.org/r/3313/#comment21059> hmmm, not 100% sure one this one, but it is probably better to close the file and then move it. ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample <https://reviewboard.asterisk.org/r/3313/#comment21060> Maybe make this a little more specific like 'ami-id' ./asterisk/trunk/tests/pbx/create_call_files/test-config.yaml <https://reviewboard.asterisk.org/r/3313/#comment21061> Does the test actually require the 'TEST_FRAMEWORK'? - Kevin Harwell On March 27, 2014, 1:06 p.m., Scott Emidy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3313/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 1:06 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23217 > https://issues.asterisk.org/jira/browse/ASTERISK-23217 > > > Repository: testsuite > > > Description > ------- > > This test uses the Pluggable Module Framework in order to convert a YAML > configuration into an executable Call File by putting it into the correct > directory, which is the 'astspooldir' directory. > > > Diffs > ----- > > ./asterisk/trunk/tests/pbx/tests.yaml 4726 > ./asterisk/trunk/tests/pbx/create_call_files/test-config.yaml PRE-CREATION > ./asterisk/trunk/tests/pbx/create_call_files/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample PRE-CREATION > ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4726 > > Diff: https://reviewboard.asterisk.org/r/3313/diff/ > > > Testing > ------- > > > Thanks, > > Scott Emidy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
