-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3411/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

* Assert if a channel is destroyed but has the snapshot staging flag set.  In 
this case the final channel destruction snapshot would never get taken.

* Assert if what we just got out of the stasis cache is not what we were 
looking for.  This assert would have saved several days searching for a bug and 
a lot of my hair.

* Assert if the music on hold message posts could not find the associated 
channel.  A crash will happen later when manager tries to send the MOH AMI 
message.  This assert catches the problem when the stasis message is posted 
instead of by the thread processing the defective message.

* Always generate a backtrace when an ast_assert() fails.


Diffs
-----

  /branches/12/res/res_musiconhold.c 411651 
  /branches/12/main/utils.c 411651 
  /branches/12/main/stasis_cache.c 411651 
  /branches/12/main/channel.c 411651 

Diff: https://reviewboard.asterisk.org/r/3411/diff/


Testing
-------

Inserted an assertion that failed to see that the backtrace is generated.


Thanks,

rmudgett

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to