----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3420/#review11556 -----------------------------------------------------------
./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3420/#comment21317> Where does this check that the call file was not deleted? ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/test-config.yaml <https://reviewboard.asterisk.org/r/3420/#comment21316> What does this test rely on that doesn't exist in the 1.8 branch? This applies to the other tests as well. ./asterisk/trunk/tests/pbx/call_file_retries_archive/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3420/#comment21318> Where does this check that the call file was archived correctly? ./asterisk/trunk/tests/pbx/call_file_retries_success/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3420/#comment21320> The Answer() here is never called and an unconditional goto would work just as well since the condition is checked again under failure@test_set. - opticron On April 4, 2014, 6:15 p.m., Scott Emidy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3420/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 6:15 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23218 > https://issues.asterisk.org/jira/browse/ASTERISK-23218 > > > Repository: testsuite > > > Description > ------- > > These tests involved checking that call files max retries are functioning as > planned through four tests: > > 1) The first test (call_file_retries_fail) required that the call file > originates a local channel to a dialplan extension that will always fail, and > checks to make sure that it ran through all of its max retries. > > 2) The second test (call_file_retries_success) involves a call file that > originates a local channel that will fail once, but then is answered before > it hits its max retries. > > 3) The third test (call_file_retries_alwaysdelete) consists of checking > whether or not the call file was deleted from the [astspooldir]'s outgoing > folder when the alwaysdelete option is set to 'no'. > > 4) The fourth and final test (call_file_retries_archive) consists of checking > whether or not the call file was placed in [astspooldir]'s outgoing_done > folder when archive is set to 'yes'. > > > Diffs > ----- > > ./asterisk/trunk/tests/pbx/tests.yaml 4935 > ./asterisk/trunk/tests/pbx/call_file_retries_success/test-config.yaml > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_success/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_fail/test-config.yaml > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_fail/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_archive/test-config.yaml > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_archive/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/test-config.yaml > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4935 > > Diff: https://reviewboard.asterisk.org/r/3420/diff/ > > > Testing > ------- > > > Thanks, > > Scott Emidy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
