----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3439/#review11613 -----------------------------------------------------------
Ship it! I could only find one problem aside from what Matt pointed out, so I've gone ahead and marked it with a "ship it!" since otherwise this is ready to go. /trunk/include/asterisk/rtp_engine.h <https://reviewboard.asterisk.org/r/3439/#comment21376> This will need to be updated to whatever version of Asterisk this actually gets added to. - Mark Michelson On April 11, 2014, 1:46 p.m., Olle E Johansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3439/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 1:46 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > the A=rtcp attribute in SDP points out a different port than the mediaport+1 > to receive RTCP on. This patch adds a new api to rtpengine and > res_rtp_asterisk and updates chan_sip to use it. > > > Diffs > ----- > > /trunk/res/res_rtp_asterisk.c 412166 > /trunk/main/rtp_engine.c 412166 > /trunk/include/asterisk/rtp_engine.h 412166 > /trunk/channels/chan_sip.c 412166 > > Diff: https://reviewboard.asterisk.org/r/3439/diff/ > > > Testing > ------- > > A massive amount of testing with a test tool for interoperability. > > > Thanks, > > Olle E Johansson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev