----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3455/ -----------------------------------------------------------
Review request for Asterisk Developers, Joshua Colp, Matt Jordan, Mark Michelson, opticron, and wdoekes. Bugs: AST-1301 and ASTERISK-19465 https://issues.asterisk.org/jira/browse/AST-1301 https://issues.asterisk.org/jira/browse/ASTERISK-19465 Repository: testsuite Description ------- Part of the effort going on with https://reviewboard.asterisk.org/r/3447/ The point of these tests is to establish requirements for developing a patch to deal with the anonymity problems described on the issues. The following charts provide the base expectations: for sendrpid=pai: | pres=allowed | pres=prohibited | ----------------------+-------------------------+-----------------------+ trust_id_outbound=no | PAI: 123, Privacy: none | | ----------------------+-------------------------+-----------------------+ trust_id_outbound=yes | PAI: 123, Privacy: none | PAI: 123, Privacy: id | ----------------------+-------------------------+-----------------------+ *PAI is abbreviated a bit in this chart for sendrpid=rpid: | pres=allowed | pres=prohibited | ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+ trust_id_outbound=no | Remote-Party-ID: "123" <sip:1...@xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:123@anonymous.invalid>party=calling;privacy=full;screen=yes | ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+ trust_id_outbound=yes | Remote-Party-ID: "123" <sip:1...@xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:1...@xxx.xxx.xxx.xxx>;party=calling;privacy=full;screen=yes | ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+ Diffs ----- /asterisk/trunk/tests/channels/SIP/tests.yaml 4958 /asterisk/trunk/tests/channels/SIP/sendrpid/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_prohib/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_prohib/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_prohib/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_prohib/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_prohib/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_allow/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_allow/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_allow/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_allow/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust/pres_allow/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_prohib/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_prohib/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_prohib/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_prohib/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_prohib/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_allow/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_allow/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_allow/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_allow/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/baseline/pres_allow/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_prohib/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_prohib/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_prohib/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_prohib/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_prohib/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_allow/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_allow/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_allow/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_allow/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust/pres_allow/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_prohib/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_prohib/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_prohib/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_prohib/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_prohib/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_allow/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_allow/sipp/send.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_allow/sipp/receive.xml PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_allow/configs/ast1/sip.conf PRE-CREATION /asterisk/trunk/tests/channels/SIP/sendrpid/pai/baseline/pres_allow/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3455/diff/ Testing ------- Checked tests against the baseline... note that the prohib variant of the rpid=pai test fails since it is including anonymized PAI data when it should be including nothing (one of the subjects of the bug report). The trust variants of each test require that a patch be written to add the trust_id_outbound setting described in comments on https://reviewboard.asterisk.org/r/3447/ (currently in development) Thanks, Jonathan Rose
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev