-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3462/#review11684
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On April 17, 2014, 8:52 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3462/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 8:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I realized that when configuring realtime PJSIP, it was not possible to 
> configure multiple permanent contacts for an AOR. This patch modifies the 
> parsing of the contact option for AORs so that multiple URIs may be presented 
> as a comma-separated list of items. Commas are in the reserved character set 
> in RFC 3261, so it is safe to use them as a separator.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/location.c 411896 
> 
> Diff: https://reviewboard.asterisk.org/r/3462/diff/
> 
> 
> Testing
> -------
> 
> I modified the testsuite's channels/pjsip/ami/show_endpoint test so that it 
> contained two contacts instead of a single one. I ensured that the 
> ContactDetail event emitted from Asterisk showed both contacts in the 
> Contacts: header and that the TotalContacts: header showed 2 contacts.
> 
> I could make this testsuite change permanent if desired, but since the change 
> was minute, I didn't feel it necessary to post a review with the change.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to