> On April 29, 2014, 2:25 p.m., opticron wrote: > > /branches/12/res/res_pjsip_sdp_rtp.c, lines 1080-1081 > > <https://reviewboard.asterisk.org/r/3472/diff/1/?file=57771#file57771line1080> > > > > I guess people don't use SRTP+video/text that often...
activate isn't really used by res_rtp_asterisk, except for DTLS-SRTP these days - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3472/#review11782 ----------------------------------------------------------- On April 23, 2014, 11:06 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3472/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 11:06 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23558 > https://issues.asterisk.org/jira/browse/ASTERISK-23558 > > > Repository: Asterisk > > > Description > ------- > > The code for queueing hold and unhold currently favors unholding over > holding. This means that if an SDP is received with host information but with > a stream state of sendonly the code will incorrectly stop musiconhold if it > has been started. > > The attached change fixes this by favoring hold instead of unhold. If an SDP > is received with 0.0.0.0 OR sendonly and hold has not been started then it is > started. If it has already been started no change occurs. Otherwise if > musiconhold has been started it is stopped. > > > Diffs > ----- > > /branches/12/res/res_pjsip_sdp_rtp.c 412900 > > Diff: https://reviewboard.asterisk.org/r/3472/diff/ > > > Testing > ------- > > Ran test before fixing and confirmed broken. Ran test after fixing and > confirmed fixed. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
