----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3027/ -----------------------------------------------------------
(Updated April 29, 2014, 1:28 p.m.) Status ------ This change has been discarded. Review request for Asterisk Developers. Repository: testsuite Description ------- This patch adds support for running Asterisk under Valgrind (say: Val-Grinned) to check for all sorts of nasty runtime bugs. This started off with a post to asterisk-dev list by nitesh.ban...@gmail.com, and he wrote and contributed the initial version. So if you find this useful, be sure to thank him. Then I made extensive changes and additions, so if the code stinks, blame me. The following has been done: - Check runtests.py arguments for --valgrind and --valgrind-gensupp flags, pass via environ to TestCase.py - Note previously existing instances of ast# logs to insure we only process new log/xml files - Increase reactor timeout by x5 when valgrind enabled - Patch to reactor_stop() to insure it does even when exceptions occur in deferred stack - Add valgrind with correct arguments into executable path - After run, check valgrind.xml for errors, parse and condense them into something more managable - If -gensup mode enabled, write suppressions to logs/(test)/ast#/valgrind.supp that can be added (manually) - A default valgrind.supp "suppressions" file is in configs/ to prevent complaints about known unfixables Notes: - valgrind can be triggered by argument to runtests.py, export VALGRIND=true, or in test-config.yaml - configs/valgrind.supp will be used if found, but tests/(test)/configs/valgrind.supp will take precedence - valgrind-gensupp mode will create example suppressions file, during which no suppressions occur Diffs ----- /asterisk/trunk/runtests.py 4350 /asterisk/trunk/lib/python/asterisk/asterisk.py 4350 /asterisk/trunk/lib/python/asterisk/Valgrind.py PRE-CREATION /asterisk/trunk/lib/python/asterisk/TestConfig.py 4350 /asterisk/trunk/lib/python/asterisk/TestCase.py 4350 /asterisk/trunk/configs/valgrind.supp PRE-CREATION /asterisk/trunk/README.txt 4350 Diff: https://reviewboard.asterisk.org/r/3027/diff/ Testing ------- Tested on 64bit and 32bit CentOS, including low cpu power conditions. Some sporadic timing issues affecting AMI/twisted operation have been seen and will be corrected. Thanks, Scott Griepentrog
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev