----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11818 -----------------------------------------------------------
/branches/11/apps/app_chanspy.c <https://reviewboard.asterisk.org/r/3505/#comment21679> spyee_bridge_autochan doesn't propogate back to the caller in this function, so it will never be free'd. This is fixed in the next version of the patch. - Jonathan Rose On April 29, 2014, 5:07 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3505/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 5:07 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23381 > https://issues.asterisk.org/jira/browse/ASTERISK-23381 > > > Repository: Asterisk > > > Description > ------- > > This is a cleanup of the patches posted by Robert Moss for ASTERISK-23381 - A > stalled review of the patch exists here: > https://reviewboard.asterisk.org/r/3331/diff/1/#index_header > > This version is made to apply to Asterisk 11 since the bug was first reported > there. > > > Diffs > ----- > > /branches/11/apps/app_chanspy.c 413071 > > Diff: https://reviewboard.asterisk.org/r/3505/diff/ > > > Testing > ------- > > 1. SIP/A calls a spy application which spies on SIP/B with the DTMF option (4 > for spy mode, 5 for whisper mode, 6 for barge) > 2. SIP/B calls SIP/C > 3. Check to see if audio is flowing from A to B and from A to C... should > start as neither. (A always hears both of the others though) > * press DTMF 5 > - now audio should flow from A to B, but from not A to C > * press DTMF 6 > - now audio should flow from A to B and A to C > 4. Hang up SIP/B > 5. Have SIP/B call SIP/C again > 6. The spy should reconnect automatically and be in barge mode > - audio should flow from A to B and A to C > * press DTMF 5 > - audio should flow from A to B, but not from A to C > * press DTMF 4 > - audio should not flow from A to either phone > > > Prior to patch: Audio from A to C could not be heard in the first check > After the patch: Audio from A to C can be heard in the first check > > All other checks work as expected in both situations. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev