----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3420/#review11830 -----------------------------------------------------------
./asterisk/trunk/lib/python/asterisk/pluggable_modules.py <https://reviewboard.asterisk.org/r/3420/#comment21695> This should happen before the if statement for the number of calls to be processed correctly. ./asterisk/trunk/tests/pbx/call_file_retries_success/test-config.yaml <https://reviewboard.asterisk.org/r/3420/#comment21696> With the change to the hangup handler, this needs to be changed to 4 since the number of channels in this case is not the same as the number of attempts. Two attempts will end up generating four channels (two halves of two local channels. - opticron On May 2, 2014, 3:52 p.m., Scott Emidy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3420/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 3:52 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23218 > https://issues.asterisk.org/jira/browse/ASTERISK-23218 > > > Repository: testsuite > > > Description > ------- > > These tests involved checking that call files max retries are functioning as > planned through four tests: > > 1) The first test (call_file_retries_fail) required that the call file > originates a local channel to a dialplan extension that will always fail, and > checks to make sure that it ran through all of its max retries. > > 2) The second test (call_file_retries_success) involves a call file that > originates a local channel that will fail once, but then is answered before > it hits its max retries. > > 3) The third test (call_file_retries_alwaysdelete) consists of checking > whether or not the call file was deleted from the [astspooldir]'s outgoing > folder when the alwaysdelete option is set to 'no'. > > 4) The fourth and final test (call_file_retries_archive) consists of checking > whether or not the call file was placed in [astspooldir]'s outgoing_done > folder when archive is set to 'yes'. > > > Diffs > ----- > > ./asterisk/trunk/tests/pbx/tests.yaml 4990 > ./asterisk/trunk/tests/pbx/call_file_retries_success/test-config.yaml > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_success/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_fail/test-config.yaml > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_fail/retries_fail.py > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_fail/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_archive/test-config.yaml > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_archive/retries_archive.py > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_archive/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/test-config.yaml > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/retries_alwaysdelete.py > PRE-CREATION > > ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4990 > > Diff: https://reviewboard.asterisk.org/r/3420/diff/ > > > Testing > ------- > > > Thanks, > > Scott Emidy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
