----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3531/#review11872 -----------------------------------------------------------
/branches/11/apps/app_chanspy.c <https://reviewboard.asterisk.org/r/3531/#comment21753> To reduce the chance of your ast_frfree issue again if someone else mucks with this I'd just put the bridge_whisper_audiohook logic in an if (bridge_connected) - Joshua Colp On May 12, 2014, 6:52 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3531/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 6:52 p.m.) > > > Review request for Asterisk Developers, Joshua Colp, kmoore, and Matt Jordan. > > > Repository: Asterisk > > > Description > ------- > > In https://reviewboard.asterisk.org/r/3505/ a behavior change in the barge > code made frames not write to the spyee channel when barging while the spyee > was not bridged. This caused the test failure. While I was at it I noticed > an unfree'd frame, so I went ahead and fixed that. > > Also, instead of locking both audiohooks and consuming them both before > unlocking them both, this patch changes it so that these will happen one at a > time. > > > Diffs > ----- > > /branches/11/apps/app_chanspy.c 413706 > > Diff: https://reviewboard.asterisk.org/r/3531/diff/ > > > Testing > ------- > > Ran testsuite test apps/chanspy/chanspy_barge before and after. With patch > it passes, without patch it doesn't. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
