----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3501/ -----------------------------------------------------------
(Updated May 12, 2014, 3:43 p.m.) Review request for Asterisk Developers. Changes ------- Addressed review concerns. Added tests for body parameters. Moved from rest_api/applications/userevents to rest_api/events/user. Bugs: ASTERISK-22697 https://issues.asterisk.org/jira/browse/ASTERISK-22697 Repository: testsuite Description ------- Tests added: 1) userevents/channel - check that the dialplan app Userevent() generated event produces correct ARI/AMI events 2) userevents/multi - check that various forms of the ARI userevent generate correct ARI & AMI events 3) userevents/invalid - check that correct result code is returned for invalid input cases Changes to ari.py made to add expected: ### return code checking for HTTP requests. Diffs (updated) ----- /asterisk/trunk/tests/rest_api/tests.yaml 5006 /asterisk/trunk/tests/rest_api/events/user/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/multi/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/multi/configs/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/multi/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/multi/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/invalid/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/invalid/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/channel/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/events/user/channel/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/events/tests.yaml PRE-CREATION /asterisk/trunk/lib/python/asterisk/ari.py 5025 Diff: https://reviewboard.asterisk.org/r/3501/diff/ Testing ------- Tests pass with userevent code. Also tested with r3496 valgrind support to insure no invalid references. Thanks, Scott Griepentrog
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev