> On June 10, 2014, 7:01 a.m., Joshua Colp wrote: > > /team/group/media_formats-reviewed/tests/test_config.c, lines 911-917 > > <https://reviewboard.asterisk.org/r/3602/diff/1/?file=59446#file59446line911> > > > > Might as well go ahead and add this back in. It can be constructed > > using ast_format_cap_get_format, ast_format_cap_iscompatible_format, and > > ast_format_cap_count.
I was looking at the old implementation of ast_format_cap_identical, it seems like it fails to verify the order is identical. Am I wrong to think that "ulaw,alaw" is different from "alaw,ulaw"? - Corey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3602/#review12106 ----------------------------------------------------------- On June 8, 2014, 3:38 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3602/ > ----------------------------------------------------------- > > (Updated June 8, 2014, 3:38 p.m.) > > > Review request for Asterisk Developers and Joshua Colp. > > > Repository: Asterisk > > > Description > ------- > > This change fixes main/config_options.c and tests/test_config.c to use the > new media framework. > > I'm unsure how to replace the check for ast_format_cap_identical, for now > it's commented out. I welcome suggestions on how to fix this, all uses of > ast_format_cap_identical in other files were just removed. > > > Diffs > ----- > > /team/group/media_formats-reviewed/tests/test_config.c 415341 > /team/group/media_formats-reviewed/main/config_options.c 415341 > /team/group/media_formats-reviewed/include/asterisk/config_options.h 415341 > > Diff: https://reviewboard.asterisk.org/r/3602/diff/ > > > Testing > ------- > > Compiled. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
