----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598/#review12112 -----------------------------------------------------------
Ship it! This is pretty sly stuff going on here. Nicely done. /branches/12/include/asterisk/res_pjsip.h <https://reviewboard.asterisk.org/r/3598/#comment22134> Place [out] after "rdata" here to indicate it's an out parameter. Also, this is just personal preference, but I tend to like out parameters to be after all in parameters. /branches/12/res/res_pjsip.c <https://reviewboard.asterisk.org/r/3598/#comment22133> Remove this comment since it doesn't add anything and the "persisted information" part of it may end up being overly narrow. - Mark Michelson On June 10, 2014, 2:12 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3598/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 2:12 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change adds persistence support to res_pjsip_pubsub. > > What does this mean? > > As subscriptions are created and destroyed their state is kept in sorcery. By > default this uses the local astdb but realtime support is also possible. If > Asterisk goes down and is restarted these subscriptions are retrieved and > recreated as if nothing had happened. > > > Diffs > ----- > > /branches/12/res/res_pjsip_pubsub.exports.in 415169 > /branches/12/res/res_pjsip_pubsub.c 415169 > /branches/12/res/res_pjsip_mwi.c 415169 > /branches/12/res/res_pjsip_exten_state.c 415169 > /branches/12/res/res_pjsip.c 415169 > /branches/12/include/asterisk/res_pjsip_pubsub.h 415169 > /branches/12/include/asterisk/res_pjsip.h 415169 > > /branches/12/contrib/ast-db-manage/config/versions/c6d929b23a8_create_pjsip_subscription_persistence_.py > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3598/diff/ > > > Testing > ------- > > Did "core stop now" and "core restart now" multiple times. Confirmed, via > wireshark, that the expected NOTIFY was sent out upon startup as if nothing > had happened. Tested using the default persistence of going to astdb and also > configured it to persist through realtime -> ODBC -> MySQL. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
