> On June 5, 2014, 3:36 p.m., Scott Griepentrog wrote: > > /asterisk/trunk/lib/python/asterisk/realtime_test_module.py, line 489 > > <https://reviewboard.asterisk.org/r/3363/diff/1/?file=56114#file56114line489> > > > > I like the idea of having the extconfig.conf built automatically from > > configured tables, which can eliminate this issue. > > > > In the interim, consider using an uncommon port such as 8306 > > (reminiscent of mysql port #).
As per Corey's suggestion, I have altered this to use a higher-numbered port. > On June 5, 2014, 3:36 p.m., Scott Griepentrog wrote: > > /asterisk/trunk/lib/python/asterisk/realtime_test_module.py, lines 247-248 > > <https://reviewboard.asterisk.org/r/3363/diff/1/?file=56114#file56114line247> > > > > This has an exception on non-string types. Recommend wrapping val > > prior to escape with a conversion function like this: > > > > def interpret(value): > > if value is None: > > return "" > > if isinstance(value, bool): > > return "yes" if value else "no" > > if isinstance(value, int): > > return str(value) > > return value > > This seems like a pretty grievous anti-pattern to employ. The documentation for the RealtimeData class in realtime_test_module states that it expects all items to be stored as strings. I'm curious how you managed to run across problems where you had non-strings in the data, especially a NoneType. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3363/#review12051 ----------------------------------------------------------- On March 15, 2014, 6:34 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3363/ > ----------------------------------------------------------- > > (Updated March 15, 2014, 6:34 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > This introduces a new pluggable module to the Asterisk testsuite intended to > assist in testing using realtime storage. The test module sets up an HTTP > server on port 8000 and services requests Asterisk makes using its > res_config_curl realtime backend. The actual data is stored in memory in > python using simple dictionaries and lists. The test module configuration > allows for data to be preloaded into python before Asterisk is started so > that Asterisk may retrieve realtime data during startup. Once AMI is > connected to Asterisk, the realtime test module hands over control to a > python module so that the test may be further controlled by the test writer. > > Along with the module are six realtime tests, each designed to test an > operation that Asterisk can attempt. The "require" operation is not tested > since we currently always claim to have the proper items stored in the > expected way. > > There are potential improvements that could be made, such as: > * Memoization of HTTP resources served by the test module. > * yaml-driven test development beyond the initial population of realtime data. > * Potentially allow for the realtime test module to be run stand-alone so > that developers can have an easy realtime store to use for testing. > > None of these are enough to prevent inclusion into the test suite though. > > > Diffs > ----- > > /asterisk/trunk/tests/tests.yaml 4836 > /asterisk/trunk/tests/realtime/update/update.py PRE-CREATION > /asterisk/trunk/tests/realtime/update/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/realtime/update/configs/ast1/sorcery.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/update/configs/ast1/extconfig.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/tests.yaml PRE-CREATION > /asterisk/trunk/tests/realtime/store/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/realtime/store/store.py PRE-CREATION > /asterisk/trunk/tests/realtime/store/configs/ast1/sorcery.conf PRE-CREATION > /asterisk/trunk/tests/realtime/store/configs/ast1/extconfig.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/static/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/realtime/static/static.py PRE-CREATION > /asterisk/trunk/tests/realtime/static/configs/ast1/modules.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/static/configs/ast1/extconfig.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/single/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/realtime/single/single.py PRE-CREATION > /asterisk/trunk/tests/realtime/single/configs/ast1/sorcery.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/single/configs/ast1/extconfig.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/multi/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/realtime/multi/multi.py PRE-CREATION > /asterisk/trunk/tests/realtime/multi/configs/ast1/sorcery.conf PRE-CREATION > /asterisk/trunk/tests/realtime/multi/configs/ast1/extconfig.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/destroy/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/realtime/destroy/destroy.py PRE-CREATION > /asterisk/trunk/tests/realtime/destroy/configs/ast1/sorcery.conf > PRE-CREATION > /asterisk/trunk/tests/realtime/destroy/configs/ast1/extconfig.conf > PRE-CREATION > /asterisk/trunk/lib/python/asterisk/realtime_test_module.py PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3363/diff/ > > > Testing > ------- > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
