> On June 24, 2014, 3:41 p.m., Mark Michelson wrote: > > trunk/include/asterisk/bridge_features.h, line 730 > > <https://reviewboard.asterisk.org/r/3649/diff/2/?file=60541#file60541line730> > > > > No need for this. A function with a void return obviously returns > > nothing :)
This is a doxygenism and is all over the place. :) > On June 24, 2014, 3:41 p.m., Mark Michelson wrote: > > trunk/include/asterisk/bridge_channel.h, line 652 > > <https://reviewboard.asterisk.org/r/3649/diff/2/?file=60540#file60540line652> > > > > This is an improper use of the \retval doxygen command. The syntax is > > \retval <return> <description>. You've just given a description. You can > > either go with > > > > \retval non-NULL The features currently set for this channel > > > > of > > > > \return The features currently set for this channel > > > > I'm not sure how a \return and \retval get along with each other, but I > > suspect it's fine. Probably should not mix them anyway. - rmudgett ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3649/#review12297 ----------------------------------------------------------- On June 24, 2014, 1:06 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3649/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 1:06 p.m.) > > > Review request for Asterisk Developers and rmudgett. > > > Bugs: AFS-78 > https://issues.asterisk.org/jira/browse/AFS-78 > > > Repository: Asterisk > > > Description > ------- > > This patch allows the current owner of a channel to define various feature > hooks to be made available once the channel has entered a bridge. > > Currently, it is only possible to attach these hooks by calling > ast_bridge_join or as_bridge_impart directly. > > > Diffs > ----- > > trunk/tests/test_channel_datastore_features.c PRE-CREATION > trunk/main/bridge_channel.c 416731 > trunk/main/bridge.c 416736 > trunk/include/asterisk/bridge_features.h 416731 > trunk/include/asterisk/bridge_channel.h 416731 > > Diff: https://reviewboard.asterisk.org/r/3649/diff/ > > > Testing > ------- > > Ensured that DTMF hooks could be attached to the channel via this mechanism > and that they became available and were executable once the channel entered a > bridge via Dial(). > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
