> On June 26, 2014, 4:13 p.m., one47 wrote: > > /branches/11/channels/chan_sip.c, line 11072 > > <https://reviewboard.asterisk.org/r/3679/diff/1/?file=61055#file61055line11072> > > > > I don't know what the RFC says, but some real-world implementations do > > not put a space between fingerprint: and the hash type. > > opticron wrote: > In scanf-style format strings, spaces mean there can be a space there but > does not require it.
Odd - I did not find this worked in the real-world, so worked-around it. Perhaps I was accidentally fixing something else? I will check into this, but I'll stand corrected for the moment. - one47 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3679/#review12342 ----------------------------------------------------------- On June 26, 2014, 3:49 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3679/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 3:49 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22961 and ASTERISK-23026 > https://issues.asterisk.org/jira/browse/ASTERISK-22961 > https://issues.asterisk.org/jira/browse/ASTERISK-23026 > > > Repository: Asterisk > > > Description > ------- > > This change does the following: > > 1. Adds SHA-256 support for DTLS-SRTP. This is done in an extensible way so > if we need to add other hashes it should be relatively easy to. > 2. Adds the ability to force "AVP" for DTLS streams for greater > interoperability. > 3. Sets the ICE role to controlled or controlling depending on offer/answer. > 4. Provides the ability to verify only fingerprint, certificate, or both. > 5. Adds DTLS negotiation to RTCP. > 6. Changes DTLS negotiation to occur after ICE negotiation completes. > 7. Adds handling of DTLS traffic before ICE negotiation has formally > completed. > > > Diffs > ----- > > /branches/11/res/res_rtp_asterisk.c 417252 > /branches/11/main/rtp_engine.c 417252 > /branches/11/include/asterisk/rtp_engine.h 417252 > /branches/11/configs/sip.conf.sample 417252 > /branches/11/channels/sip/include/sip.h 417252 > /branches/11/channels/chan_sip.c 417252 > > Diff: https://reviewboard.asterisk.org/r/3679/diff/ > > > Testing > ------- > > Tested inbound and outbound calls against: > > Chrome > Yandex Browser > Opera > Maxthon > Firefox > > Note that hold/unhold only currently works against Chrome based browsers. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev