----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3690/#review12397 -----------------------------------------------------------
branches/12/main/causes.c <https://reviewboard.asterisk.org/r/3690/#comment22613> Since this is specific to sip, I'd place it in something that calls that out. Maybe sip_causes? - Matt Jordan On June 30, 2014, 3:04 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3690/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 3:04 p.m.) > > > Review request for Asterisk Developers and Corey Farrell. > > > Repository: Asterisk > > > Description > ------- > > This corrects two issues with the extra field information in Asterisk 12+ in > channel event logs. > > It is possible to inject custom values into the dialstatus provided by > ast_channel_dial_type() Stasis messages that fall outside the enumeration > allowed for the DIALSTATUS channel variable. CEL now filters for the allowed > values and ignores other values. > > The "hangupsource" extra field key is always blank if the far end channel is > a chan_pjsip channel. This is because the hangupsource is never set for the > pjsip channel driver. This change sets the hangupsource whenever a hangup is > queued for chan_pjsip channels. > > This corrects an issue with the pjsip channel driver where the hangupcause > information was not being set properly. This required that the > hangup_sip2cause functionality be pulled out of chan_sip and chan_pjsip into > main/causes.c so that it could also be utilized by res_pjsip_session. > > > Diffs > ----- > > branches/12/tests/test_cel.c 417545 > branches/12/res/res_pjsip_session.c 417545 > branches/12/main/cel.c 417545 > branches/12/main/causes.c PRE-CREATION > branches/12/include/asterisk/causes.h 417545 > branches/12/channels/chan_sip.c 417545 > branches/12/channels/chan_pjsip.c 417545 > > Diff: https://reviewboard.asterisk.org/r/3690/diff/ > > > Testing > ------- > > Tested all three portions of the patch manually and the dial status portion > using the included unit test. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
