----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/#review12466 -----------------------------------------------------------
The findings I have are pretty minor, but I'm not sure we should Ship It! until the code that this will test is ready. You'll probably find some more things to tweak when that occurs (or who knows, maybe not?) /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/full_state.py <https://reviewboard.asterisk.org/r/3673/#comment22745> Preamble (etc.) /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/sipp/list_subscribe.xml <https://reviewboard.asterisk.org/r/3673/#comment22746> You may want to use separate variables for your checks in here. I've run into a few issues before in the past where a subsequent assignment to a variable meant that a reference check missed a previous error. This would apply to the other SIPp scenario as well. /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/rls_integrity.py <https://reviewboard.asterisk.org/r/3673/#comment22735> This should have the standard preamble and GPL disclaimer. This would apply to all of the new Python files in this review. - Matt Jordan On June 26, 2014, 5:40 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3673/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 5:40 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23870 > https://issues.asterisk.org/jira/browse/ASTERISK-23870 > > > Repository: testsuite > > > Description > ------- > > This changeset implements the nominal resource list tests outlined on this > page: > https://wiki.asterisk.org/wiki/display/AST/Resource+List+Subscription+Test+Plan > > There are six tests: > 1. Subscription Establishment: Simply ensures that Asterisk responds with a > 200 OK when we subscribe to a resource list and that the 200 OK has a > Require: eventlist header in it. > 2. Initial NOTIFY: Validates the initial NOTIFY body that Asterisk sends when > subscribing to a resource list. > 3. Full State: Establishes a subscription to a resource list and then changes > the state of a resource. Ensures that Asterisk sends a NOTIFY with full state > of the list. > 4. Partial State: Establishes a subscription to a resource list and then > changes the state of a resource. Ensures that Asterisk sends a NOTIFY with > partial state, with only the state of the resource whose state was changed. > 5. Resubscription Full State: Establishes a subscription and then > resubscribes. Ensures that even though partial state is configured, the > NOTIFY that Asterisk sends in response to the resubscription has full state > of the list. > 6. Termination Full State: Establishes a subscription and then terminates the > subscription. Ensures that even though partial state is configured, the > NOTIFY that Asterisk sends in response to the termination has full state of > the list. > > > Diffs > ----- > > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/tests.yaml > 5168 > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/tests.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/rls_integrity.py > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/tests.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/tests.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/test-config.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/termination.py > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/sipp/termination.xml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/test-config.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/sipp/list_subscribe.xml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/test-config.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/sipp/resubscribe.xml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/resubscribe.py > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/test-config.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/sipp/list_subscribe.xml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/partial_state.py > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/test-config.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/notify.py > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/test-config.yaml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/sipp/list_subscribe.xml > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/full_state.py > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/team/group/rls-tests/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/team/group/rls-tests/lib/python/asterisk/pcap.py 5168 > > Diff: https://reviewboard.asterisk.org/r/3673/diff/ > > > Testing > ------- > > This may seem odd, but this is completely untested. This is because these > tests are being written against an unimplemented feature. There are almost > certainly some mistakes made in these tests, so I figured I'd get those > caught by reviewers early. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
