-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/
-----------------------------------------------------------
(Updated July 3, 2014, 3:40 p.m.)
Review request for Asterisk Developers, kmoore and Matt Jordan.
Changes
-------
Hit kmoore's findings
Repository: testsuite
Description
-------
11 part test:
1 - Remove an extension with a priority
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes
the test fail
2 - Remove an entire existing extension
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes
the test fail
3 - Add an extension
If the manager command fails, a failure token will be set
If the extension fails to run, an expected user event will not be
generated and the test will fail
4 - Add an extension with a CID match that doesn't match the originated channel
If the manager command fails, a failure token will be set
If the extension runs, a user event will be generated that makes the test
fail
5 - Add an extension with a CID match that should match the originated channel
If the manager command fails, a failure token will be set
If the extension fails to run, an expected user event will not be
generated and the test will fail
6 - Add an extension that replaces an existing priority
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes
the test fail
If the replacement extension doesn't run, an expected user event will not
be generated and the test will fail
7 - Attempt to add an extension that would replace an existing priority, but
don't allow replacement
If the manager command doesn't fail, a failure token will be set
If the original extension doesn't run, an expected user event will not be
generated and the test will fail
If the replacement extension runs, a user event will be generated that
makes the test fail
8 - Remove an extension at a specific priority with caller ID matching
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes
the test fail
The originate is checked by means of a user event on a separate priority
taht is not removed
9 - Attempt DialplanAddExtension without priority set
If the manager command doesn't fail, a failure token will be set
10 - Attempt DialplanAddExtension without application set
If the manager command doesn't fail, a failure token will be set
11 - Attempt DialplanRemoveExtension on an extension that does not exist
If the manager command doesn't fail, a failure token will be set
Diffs (updated)
-----
/asterisk/trunk/tests/pbx/tests.yaml 5204
/asterisk/trunk/tests/pbx/manager_extensions/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/pbx/manager_extensions/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3660/diff/
Testing
-------
Removed execution of many of the test AMI commands to guarantee that if above
failures occurred that the test would fail
Thanks,
Jonathan Rose
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
