----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3724/#review12524 -----------------------------------------------------------
/branches/12/CHANGES <https://reviewboard.asterisk.org/r/3724/#comment22783> This should be in a new 12.5.0 section. /branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3724/#comment22780> Nit: Pull the assignment out of the if test. Also the line indention is now excessive. /branches/12/channels/chan_pjsip.c <https://reviewboard.asterisk.org/r/3724/#comment22782> The S_OR is not needed for a stringfield. Just pass session->endpoint->accountcode. /branches/12/contrib/ast-db-manage/config/versions/1d50859ed02e_create_accountcode.py <https://reviewboard.asterisk.org/r/3724/#comment22781> A size of twenty? Seems potentially too small. Is there precedent for accountcode to be this small? - rmudgett On July 7, 2014, 9:30 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3724/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 9:30 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24000 > https://issues.asterisk.org/jira/browse/ASTERISK-24000 > > > Repository: Asterisk > > > Description > ------- > > Most channel drivers let you specify a default accountcode for channels > associated with a particular endpoint/peer/thing. chan_pjsip/res_pjsip does > not. > > This patch adds a new setting to the endpoint object (accountcode!) that does > that. > > > Diffs > ----- > > /branches/12/res/res_pjsip/pjsip_configuration.c 418167 > /branches/12/res/res_pjsip.c 418167 > /branches/12/include/asterisk/res_pjsip.h 418167 > > /branches/12/contrib/ast-db-manage/config/versions/1d50859ed02e_create_accountcode.py > PRE-CREATION > /branches/12/configs/pjsip.conf.sample 418167 > /branches/12/channels/chan_pjsip.c 418167 > /branches/12/CHANGES 418167 > > Diff: https://reviewboard.asterisk.org/r/3724/diff/ > > > Testing > ------- > > See https://reviewboard.asterisk.org/r/3725 > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
