> On July 12, 2014, 2:33 a.m., rmudgett wrote: > > /branches/1.8/main/astobj2.c, line 228 > > <https://reviewboard.asterisk.org/r/3756/diff/1/?file=62851#file62851line228> > > > > Hmm. If delta is zero we shouldn't be logging it since the caller just > > wants the number of current references and not to change it.
We're actually already not logging for delta == 0. - Corey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3756/#review12588 ----------------------------------------------------------- On July 12, 2014, 2:13 a.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3756/ > ----------------------------------------------------------- > > (Updated July 12, 2014, 2:13 a.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Repository: Asterisk > > > Description > ------- > > This incorporates the ideas from r3572, with an improvement. REF_DEBUG is > still effective when ao2_ref(obj, -1) is run on an object that is already > destroyed. > > In addition refcounter.py is updated to use delta's to track the current > reference count. This works around a race condition where **destroyed** > could be printed before the unref from 2. > > > Diffs > ----- > > /branches/1.8/main/astobj2.c 417500 > /branches/1.8/contrib/scripts/refcounter.py 417486 > > Diff: https://reviewboard.asterisk.org/r/3756/diff/ > > > Testing > ------- > > Verified that all false reported leaks are no longer. > > One thing I noticed, the updated refcounter.py took 40 seconds to process a > file when the same file was processed in 30 seconds before the change. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
