----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3792/#review12655 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On July 15, 2014, 11:17 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3792/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 11:17 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > The res_fax module does some sanity checks on the frames it receives to make > sure they have both the expected frame type and subclass. In the media > formats branch the subclass is no longer a union, meaning that all fields are > compared. The res_fax module initialized the integer field to -1 but on audio > frames this is actually 0, causing the comparison to fail despite the audio > frame being expected. This change makes the check more specific, and does an > actual format comparison (since the format pointer may be of the same format > but a difference structure). > > > Diffs > ----- > > /team/group/media_formats-reviewed-trunk/res/res_fax.c 418628 > > Diff: https://reviewboard.asterisk.org/r/3792/diff/ > > > Testing > ------- > > PJSIP fax tests now pass happily. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
