-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3817/
-----------------------------------------------------------

(Updated July 17, 2014, 2:27 p.m.)


Review request for Asterisk Developers, Matt Jordan and Mark Michelson.


Changes
-------

Fix some off-nominal ref-leaks.
Fix a crash where URI is specified as just 'sip:'
Fix tab completion for URI (it was showing endpoints -- URI shouldn't do tab 
completion)

I'm not sure if there are other things I should be checking in my function for 
checking if a string is a URI, and it PJSIP has a better way of checking if a 
string is a URI, that might actually be a better approach.


Repository: Asterisk


Description
-------

Example:

Action: PJSIPNotify
URI: sip:10.10.10.10

pjsip send notify uri <type> uri <uri> [uri...]


Adds the ability to use URIs with the PJSIP notify commands instead of 
endpoints. These mostly work the same as the endpoint notifications.


Diffs (updated)
-----

  /trunk/res/res_pjsip_notify.c 418783 
  /trunk/res/res_pjsip.c 418783 
  /trunk/include/asterisk/res_pjsip.h 418783 

Diff: https://reviewboard.asterisk.org/r/3817/diff/


Testing
-------

Used existing endpoint notification and compared it to similar notifies done 
against URIs.  The outgoing messages looked the same as far as the details I 
was concerned with went.


Thanks,

Jonathan Rose

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to