----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3825/#review12746 -----------------------------------------------------------
The mechanics of the test are all good as far as I can tell. However, given my comments from your Asterisk implementation review, the pjsip.conf will need to be updated to use a default outbound endpoint. - Mark Michelson On July 17, 2014, 9:51 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3825/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 9:51 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and Mark Michelson. > > > Repository: testsuite > > > Description > ------- > > https://reviewboard.asterisk.org/r/3817/ adds the ability to send notify to > URIs with PJSIP endpoints while before it could only send to established > endpoints with registered aors/contacts. > > This patch adds a test (thankfully I had already written a bunch that used > endpoints) to test that this is functional and includes the same sort of data > that would be included when sending these messages to endpoints. No peers are > defined in the configuration and some additional values are set in the > headers... something about lettuce. > > > Diffs > ----- > > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/to_uri/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/to_uri/sipp/options.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/to_uri/configs/ast1/pjsip.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/tests.yaml 5254 > > Diff: https://reviewboard.asterisk.org/r/3825/diff/ > > > Testing > ------- > > Ran this test as well as all the existing notify tests to confirm that the > old tests weren't broken by the changes made in r3817. > > Varied expectations of the SIPP scenario so that Romaine was just called > Roman (who has ever heard of Roman lettuce?) and received the expected > failure. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
