----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3830/#review12775 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On July 18, 2014, 2:15 p.m., Sean Bright wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3830/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 2:15 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > When configuring Asterisk to build against a version of pjproject installed > in a non-standard location, the checks for "PJSIP Transaction Group Lock > Support" and "PJSIP Media Stream Replacement Support" fail. This is because > the secondary checks are not taking the CFLAGS and LIBS returned by the > pkg-config check into account. > > Given an install of pjproject at /opt/pjsip, the following calls to configure > fail: > > $ ./configure --with-pjproject=/opt/pjsip > $ PKG_CONFIG_PATH=/opt/pjsip/lib/pkgconfig ./configure > > The first fails because the only check we do for pjproject is with pkg-config > and the two related checks will not be run because the first fails. The > second incorrectly determines that the two optional features are not present > when they are, causing a failure at compile time. This works: > > $ PKG_CONFIG_PATH=/opt/pjsip/lib/pkgconfig ./configure > --with-pjproject=/opt/pjsip > > Because the primary check succeeds with pkg-config and the optional features > succeed using the PJPROJECT_DIR variable setup by the --with-pjproject > argument. > > While the included diff is certainly not the cleanest, it allows me to > configure and compile Asterisk using: > > $ PKG_CONFIG_PATH=/opt/pjsip/lib/pkgconfig ./configure > > > Diffs > ----- > > /trunk/configure.ac 418979 > /trunk/configure UNKNOWN > > Diff: https://reviewboard.asterisk.org/r/3830/diff/ > > > Testing > ------- > > Configured, compiled. > > > Thanks, > > Sean Bright > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
