----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/#review12783 -----------------------------------------------------------
Two points: 1) This was technically ready for review prior to feature freeze, and hence is a candidate for Asterisk 13. 2) The CHANGES file needs to be updated noting the new feature in app_voicemail. /branches/12/apps/app_voicemail.c <https://reviewboard.asterisk.org/r/3829/#comment23097> tmp is never a good variable name. I'd pick something more descriptive. /branches/12/apps/app_voicemail.c <https://reviewboard.asterisk.org/r/3829/#comment23098> This needs to be structured differently. It should be: for each space separate e-mail to send to { if (check_mime(vmu->fullname)) { ... } else { fprintf(p, "To: ..." ); } } Right now, if we have a space separated list of e-mail addresses, we won't check if the full name needs mime encoding. This will incorrectly construct the To headers in such a situation. - Matt Jordan On July 18, 2014, 1:35 p.m., Jacob Barber wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3829/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 1:35 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24045 > https://issues.asterisk.org/jira/browse/ASTERISK-24045 > > > Repository: Asterisk > > > Description > ------- > > Currently voicemail to email only works with a single email. This patch > allows a user to use a space separated list of emails (up to 512 characters > long), where the user would like for the emails to be sent. This is useful > for people who don't want to go through setting up mailing groups, or for > people who host provide VoIP services with asterisk as a backend, where their > customers don't know how to set up mailing groups. > > > Diffs > ----- > > /branches/12/apps/app_voicemail.c 418713 > > Diff: https://reviewboard.asterisk.org/r/3829/diff/ > > > Testing > ------- > > Tested calling and sending voicemails using the mysql realtime database and > using the standard voicemail.conf implementation. > > > Thanks, > > Jacob Barber > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev