----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3844/#review12869 -----------------------------------------------------------
Ship it! /branches/1.8/apps/app_stack.c <https://reviewboard.asterisk.org/r/3844/#comment23236> Update \since doxygen comments with the next version of 1.8. - Matt Jordan On July 23, 2014, 4:43 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3844/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 4:43 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: AST-1391 > https://issues.asterisk.org/jira/browse/AST-1391 > > > Repository: Asterisk > > > Description > ------- > > Using DYNAMIC_FEATURES with a Gosub application as the mapped application > does not work. It does not work because Gosub just pushes the current > dialplan context, exten, and priority onto a stack and sets the specified > Gosub location. Gosub does not have a dialplan execution loop to run > dialplan like Macro. > > * Made the DYNAMIC_FEATURES application mapping feature call > ast_app_exec_macro() and ast_app_exec_sub() for the Macro and Gosub > applications respectively. > > * Backported ast_app_exec_macro() and ast_app_exec_sub() from v11 to execute > dialplan routines from the DYNAMIC_FEATURES application mapping feature. > > NOTE: This issue does not affect v12+ because it already does what this patch > implements. > > > Diffs > ----- > > /branches/1.8/main/features.c 419341 > /branches/1.8/main/app.c 419341 > /branches/1.8/include/asterisk/app.h 419341 > /branches/1.8/apps/app_stack.c 419341 > > Diff: https://reviewboard.asterisk.org/r/3844/diff/ > > > Testing > ------- > > Triggered DYNAMIC_FEATURES mapped to the following applications: > Playback > Gosub > Macro > > The Playback played the file, the Gosub and Macro applications executed their > respective dialplan sections. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev