----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3852/#review12878 -----------------------------------------------------------
team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23238> function curly location team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23248> put blank line between variable declarations and code break long line team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23242> This should not be necessary. The zombie stasis channel (old_chan) is going to die. team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23240> I don't think this comment is needed. Zombies drop like flies in winter. :) team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23246> This is one of those silly functions that can never fail but is defined to return a failure. Also most callers don't care about the return code because it can never fail. On the never gonna happen failure: ast_datastore_free(datastore); team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23247> This should be a void function since even you don't care about the return value. team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23245> ast_datastore_free(datastore); team/group/ari-greedy-atxfer/res/res_stasis.c <https://reviewboard.asterisk.org/r/3852/#comment23241> RAII_VAR could be eliminated by saving send_msg_snapshot() ret value and calling ao2_cleanup(). - rmudgett On July 25, 2014, 8:20 a.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3852/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 8:20 a.m.) > > > Review request for Asterisk Developers, Mark Michelson and rmudgett. > > > Bugs: ASTERISK-23941 > https://issues.asterisk.org/jira/browse/ASTERISK-23941 > > > Repository: Asterisk > > > Description > ------- > > This handles the situation where a channel is masqueraded out of stasis to go > elsewhere. It ensures that the correct StasisEnd message is sent and performs > other cleanup necessary to prevent spurious messages from reaching Stasis > applications that aren't prepared for them. > > > Diffs > ----- > > team/group/ari-greedy-atxfer/res/res_stasis.c 419315 > > Diff: https://reviewboard.asterisk.org/r/3852/diff/ > > > Testing > ------- > > Used the AMI Bridge command to pull the channel currently in Stasis() into a > non-Stasis bridge and verified the messages coming back. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
