----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3893/#review13097 -----------------------------------------------------------
Ship it! This applies to 1.8+ - Joshua Colp On Aug. 7, 2014, 9:29 p.m., ebroad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3893/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 9:29 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24178 > https://issues.asterisk.org/jira/browse/ASTERISK-24178 > > > Repository: Asterisk > > > Description > ------- > > From the issue: > > " > Long story short, we set fromdomainport to STANDARD_SIP_PORT if it is not set > by the user in fromdomain(see > http://doxygen.asterisk.org/trunk/df/df0/chan__sip_8c-source.html#l30599). > The issue is, in two places, we do the following: > > int ourport = (p->fromdomainport) ? p->fromdomainport : > ast_sockaddr_port(&p->ourip); > > Which means we will always use fromdomainport even if it wasn't actually set > by the user. A side effect of this is when using SIP over TLS, an MWI > response will always include port 5060 in the Message-Account field even > though TLS uses 5061 (see > http://doxygen.asterisk.org/trunk/df/df0/chan__sip_8c-source.html#l15086). > > The attached patch resolves this issue. > " > > > Diffs > ----- > > trunk/channels/chan_sip.c 420308 > > Diff: https://reviewboard.asterisk.org/r/3893/diff/ > > > Testing > ------- > > Made and received calls without issue. Tested MWI notifications as well. > > > Thanks, > > ebroad > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev