----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3987/#review13282 -----------------------------------------------------------
Ship it! Ship It! - Joshua Colp On Sept. 10, 2014, 3:56 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3987/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 3:56 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24211 > https://issues.asterisk.org/jira/browse/ASTERISK-24211 > > > Repository: Asterisk > > > Description > ------- > > This fixes a situation in Asterisk 1.8 and 11 where ast_channel_bridge could > cause a bouncing native bridge. In the case of the dial_LS_options test, this > was a remote RTP bridge which caused the audio path to continually cycle > between Asterisk and the remote endpoints generating a large number of SIP > messages and delaying the test long enough to cause it to fail (checking > timing was part of the test). The root cause was that the code to decide > whether to use native bridging was expecting a time-remaining value of 0 to > be the default instead of the actual default value of -1. A value of 0 or > negative numbers could also be generated by preceding code in some > circumstances. Both issues are addressed in this patch. > > > Diffs > ----- > > branches/1.8/main/channel.c 422898 > > Diff: https://reviewboard.asterisk.org/r/3987/diff/ > > > Testing > ------- > > Verified that the test (11-only) operated correctly with this patch. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
