----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4000/#review13356 -----------------------------------------------------------
Ship it! Ship It! - Mark Michelson On Sept. 18, 2014, 6:26 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4000/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 6:26 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: AFS-162 > https://issues.asterisk.org/jira/browse/AFS-162 > > > Repository: Asterisk > > > Description > ------- > > Outgoing PJSIP calls can result in non-negotiated formats listed in the > channel's native formats if video formats are listed in the endpoint's > configuration. The resulting call could then use a non-negotiated format > resulting in one way audio. > > * Simplified the update of session->req_caps in set_caps(). Why do something > in five steps when only one is needed? > > > Diffs > ----- > > /branches/13/res/res_pjsip_sdp_rtp.c 423446 > /branches/13/channels/chan_pjsip.c 423446 > > Diff: https://reviewboard.asterisk.org/r/4000/diff/ > > > Testing > ------- > > Configured PJSIP endpoints with: allow=!all,h264,g722,h263,ulaw,h263p,alaw > Called from D40 with g722 among other formats enabled to a Polycom that > negotiates ulaw. > Before the patch, Asterisk would send g722 frames to the Polycom. The > resulting call had one way audio because the Polycom does not understand g722. > After the patch, Asterisk sends ulaw frames to the Polycom. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
