----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4014/#review13374 -----------------------------------------------------------
Ship it! Ship It! - opticron On Sept. 22, 2014, 1:10 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4014/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 1:10 p.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Repository: Asterisk > > > Description > ------- > > In Asterisk 13, the format rewrite caused CDR and CEL unit tests to have > FRACKs because they have no formats on the channels they create. In revision > 423414 of Asterisk 13, I introduced an independent change that is intended to > prevent unnecessary FRACKs by returning early when attempting to set up > translation paths if any channel has no formats set. Unfortunately, this > resulted in huge breakage of the CDR and CEL unit tests. > > The change introduced in this review is to set the ulaw format on channels > created by the CEL and CDR unit tests. This way, the tests are passing again. > Event better, they now pass FRACK-free. > > > Diffs > ----- > > /branches/13/tests/test_cel.c 423656 > /branches/13/tests/test_cdr.c 423656 > > Diff: https://reviewboard.asterisk.org/r/4014/diff/ > > > Testing > ------- > > Ran CDR and CEL unit tests with and without the change. Without this patch, > things are pretty disastrous in the CEL tests (i.e. Asterisk crashes). And > the CDR tests have FRACKs in them. With the patch, all CDR and CEL unit tests > pass with no FRACKs. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
