> On Sept. 29, 2014, 7:47 p.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_nat.c, line 49 > > <https://reviewboard.asterisk.org/r/4032/diff/1/?file=67680#file67680line49> > > > > What will this do for UDP transport? For those the transport should be > > empty. > > opticron wrote: > "udp" is also a valid transport along with "tls", "ws", and others. Is > there a benefit to leaving it blank if the transport is UDP?
Makes the message smaller? (I'm on a smaller message kick, it seems) Otherwise drop. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4032/#review13400 ----------------------------------------------------------- On Sept. 29, 2014, 7:25 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4032/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 7:25 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > If contact rewriting is enabled but the contact differs in transport from > what is actually being used, messages after the initial INVITE transaction > can be sent to an incorrect transport/port combination. In the case where > this bug occurred the remote party never received a BYE since it was sent to > the remote party's TCP port over UDP. > > > Diffs > ----- > > branches/12/res/res_pjsip_nat.c 424094 > > Diff: https://reviewboard.asterisk.org/r/4032/diff/ > > > Testing > ------- > > Ensured that this patch allowed the BYE to be sent properly. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev