----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4045/ -----------------------------------------------------------
(Updated Oct. 4, 2014, 7:21 p.m.) Status ------ This change has been marked as submitted. Review request for Asterisk Developers. Changes ------- Committed in revision 424569 Bugs: ASTERISK-24385 https://issues.asterisk.org/jira/browse/ASTERISK-24385 Repository: Asterisk Description ------- process_sdp leaks on an error path where crypto lines are expected but not provided. It appears this was fixed during the media format updates. Version 13+ does goto process_sdp_cleanup, I have not tested in 13+, but in 11/12 it is an error to run offered_media_list_destroy during this error handler. This bug was found via tests/channels/SIP/SDP_offer_answer and tests/channels/SIP/noload_res_srtp_attempt_srtp. In both cases the tests currently cause a leak in 11/12. If the code is updated to goto process_sdp_cleanup it causes these tests to fail, that is why I created the label process_sdp_cleanup_b to skip offered_media_list_destroy. Diffs ----- /branches/11/channels/chan_sip.c 424335 Diff: https://reviewboard.asterisk.org/r/4045/diff/ Testing ------- Yes Thanks, Corey Farrell
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev