> On Oct. 7, 2014, 6:45 p.m., Joshua Colp wrote: > > I don't think this goes far enough. What if I receive no candidates for > > RTCP? It would still crash. > > Kevin Harwell wrote: > I tested for this. The only time it crashes is when there are no RTP > candidates in the list. If there are no RTCP candidates in the list it does > not crash.
I still think we should do it as that's relying on undocumented behavior. In fact the documentation says the opposite - that there must be at least one candidate per component. If that becomes true we are hosed. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4039/#review13462 ----------------------------------------------------------- On Oct. 1, 2014, 3:43 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4039/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 3:43 p.m.) > > > Review request for Asterisk Developers and Joshua Colp. > > > Bugs: ASTERISK-24383 > https://issues.asterisk.org/jira/browse/ASTERISK-24383 > > > Repository: Asterisk > > > Description > ------- > > When starting ice if there is not at least one remote ice candidate with an > RTP component asterisk will crash. This is due to an assertion in pjnath as > it expects at least one candidate with an RTP component. Added a check to > make sure at least one candidate contains an RTP component. > > > Diffs > ----- > > branches/12/res/res_rtp_asterisk.c 424285 > > Diff: https://reviewboard.asterisk.org/r/4039/diff/ > > > Testing > ------- > > Sent asterisk a list of ice candidates containing only RTCP components (no > RTP ones) and observed the crash. After applying the patch ran the scenario > again and it did not crash. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
