> On Oct. 9, 2014, 7:12 a.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/run-test, line 42 > > <https://reviewboard.asterisk.org/r/4051/diff/2/?file=67875#file67875line42> > > > > nitpick: As this is a global, it should be LOGGER, not logger. > > > > (Yes, I'm sure this is wrong in lots of places still in the testsuite > > :-) > > wdoekes wrote: > Hm. That's not a python convention. > > Uppercase is only used for constants. (A logger object is not one.) > > But I can certainly live with the convention here.
Heh. I think I just blindly followed pylint's complaints. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4051/#review13471 ----------------------------------------------------------- On Oct. 9, 2014, 8:49 a.m., wdoekes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4051/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 8:49 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-20784 > https://issues.asterisk.org/jira/browse/ASTERISK-20784 > > > Repository: testsuite > > > Description > ------- > > Old bug from end of 2012: under the right circumstances, a leg never gets > destroyed, resulting in file leaks and other nastiness. > > This tests that scenario and the fix as presented in patch_asterisk_20784.txt. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/SIP/tests.yaml 5684 > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/sipp/bob.xml > PRE-CREATION > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/sipp/alice.xml > PRE-CREATION > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/run-test > PRE-CREATION > > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/configs/ast1/sip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4051/diff/ > > > Testing > ------- > > Before applying patch_asterisk_20784.txt: > > > <?xml version="1.0" encoding="utf-8"?> > <testsuite errors="0" failures="1" name="AsteriskTestSuite" tests="1" > time="16.05"> > <testcase name="tests/channels/SIP/no_ack_dialog_cleanup" time="16.05"> > <failure>Running ['tests/channels/SIP/no_ack_dialog_cleanup/run-test'] ... > [Oct 08 12:26:54] WARNING[10545]: __main__:104 ret: Expected 0 sip dialog > objects: > name: 42da441f7021d3ff2b1c194b124395f8@127.0.0.1:5060 > type: dialog > objflags: 0 > refcount: 1 > </failure> > </testcase> > </testsuite> > > > After applying: > > > <?xml version="1.0" encoding="utf-8"?> > <testsuite errors="0" failures="0" name="AsteriskTestSuite" tests="1" > time="16.06"> > <testcase name="tests/channels/SIP/no_ack_dialog_cleanup" time="16.06"/> > </testsuite> > > > Thanks, > > wdoekes > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev