> On Oct. 9, 2014, 11:02 a.m., Matt Jordan wrote: > > asterisk/trunk/tests/phoneprov/res_phoneprov/run-test, lines 49-50 > > <https://reviewboard.asterisk.org/r/4061/diff/1/?file=67886#file67886line49> > > > > You may want to use a LOGGER.error() here before re-raising the > > exception. > > > > Since this is in a separate process, runtests.py *should* capture that > > and spit it out, but just to be safe, the LOGGER error message will > > definitely provide the reason why the test failed.
The traceback and error message get printed twice already. I exercised that a lot. :) > On Oct. 9, 2014, 11:02 a.m., Matt Jordan wrote: > > asterisk/trunk/tests/phoneprov/res_phoneprov/test-config.yaml, lines 10-11 > > <https://reviewboard.asterisk.org/r/4061/diff/1/?file=67887#file67887line10> > > > > You may want to add Python dependencies on 'email'. > > > > The HTTP libraries are a bit trickier, since you fall back to one if > > the other isn't available. The dependency checking isn't good enough to > > handle that - although if you'd like, you could add a dependency on > > 'httplib', since twisted doesn't support Python 3. I'll add these before I commit. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4061/#review13476 ----------------------------------------------------------- On Oct. 8, 2014, 6:46 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4061/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 6:46 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > This is the first test for res_phoneprov. > > > Diffs > ----- > > asterisk/trunk/tests/tests.yaml 5690 > asterisk/trunk/tests/phoneprov/tests.yaml PRE-CREATION > asterisk/trunk/tests/phoneprov/res_phoneprov/test-config.yaml PRE-CREATION > asterisk/trunk/tests/phoneprov/res_phoneprov/run-test PRE-CREATION > asterisk/trunk/tests/phoneprov/res_phoneprov/configs/ast1/users.conf > PRE-CREATION > asterisk/trunk/tests/phoneprov/res_phoneprov/configs/ast1/phoneprov.conf > PRE-CREATION > asterisk/trunk/tests/phoneprov/res_phoneprov/cfgex.txt PRE-CREATION > asterisk/trunk/tests/phoneprov/res_phoneprov/cfgbase.txt PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4061/diff/ > > > Testing > ------- > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
