----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/#review13533 -----------------------------------------------------------
/asterisk/trunk/runtests.py <https://reviewboard.asterisk.org/r/4080/#comment24062> I'd remove the "NOTICE:". We don't use that nomenclature elsewhere that I'm aware of. /asterisk/trunk/runtests.py <https://reviewboard.asterisk.org/r/4080/#comment24063> While the extra parantheses are probably needed, generally, this doesn't feel like the pythonic way to write this (although the original code isn't either). You shouldn't have to explicitly test for 0 or not 0. self.passed = ((p.returncode and self.test_config.expect_pass) or (not p.returncode and not self.test_config.expect_pass)) This will evaluate self.passed to a boolean still. - Matt Jordan On Oct. 15, 2014, 9:33 a.m., jbigelow wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4080/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 9:33 a.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > When the 'expected-result' (or 'expectedResult') YAML property for test > configuration is set to False and the test fails, the test should be marked > as passed. However it is marked as failed. This patch should fix the issue so > that tests are marked as passed in this scenario. > > Additionally: > * Check if p.returncode is not zero so self.passed is a boolean rather than > an int in some cases. > * Added some print statements to make it clear why a test was marked as > passed or failed when the 'expected-result' YAML property is set to False. > * Added text to the failure message so it's easily known when looking at the > results file that the test was expected to fail but passed and therefore > marked as failed. > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5726 > /asterisk/trunk/lib/python/asterisk/test_config.py 5726 > > Diff: https://reviewboard.asterisk.org/r/4080/diff/ > > > Testing > ------- > > Tested the various scenarios and they all seem to properly work as expected > now. > > > Thanks, > > jbigelow > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
