----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4089/#review13546 -----------------------------------------------------------
branches/12/main/config.c <https://reviewboard.asterisk.org/r/4089/#comment24076> In the case of retrieving a variable I don't think this will retrieve the correct information. Since the search is done from the root it'll find the first occurrence. My suggestion for test change will confirm it. - Joshua Colp On Oct. 16, 2014, 3:37 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4089/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 3:37 p.m.) > > > Review request for Asterisk Developers and Joshua Colp. > > > Repository: Asterisk > > > Description > ------- > > Fix infinite loop when calling ast_variable_retrieve inside a > ast_category_browse loop when there are more than 1 category with the same > name. > > 1 line removed from ast_category_browse_filtered. > A unit test added. > Language updated in config.h for ast_category_browse (not necessarily related > to this issue). > > > Diffs > ----- > > branches/12/tests/test_config.c 425698 > branches/12/main/config.c 425698 > branches/12/include/asterisk/config.h 425698 > > Diff: https://reviewboard.asterisk.org/r/4089/diff/ > > > Testing > ------- > > Existing and new unit test pass. > Testsuite tests/manager/config pass. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev