----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4112/#review13595 -----------------------------------------------------------
Ship it! Sounds good. Note that the following three tests also require chan_sip. /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml <https://reviewboard.asterisk.org/r/4112/#comment24109> Also requires chan_sip. /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml <https://reviewboard.asterisk.org/r/4112/#comment24107> Also requires chan_sip. /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml <https://reviewboard.asterisk.org/r/4112/#comment24108> Also requires chan_sip. - wdoekes On Oct. 27, 2014, 7:41 a.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4112/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 7:41 a.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > PJSIP fax tests are missing dependency on chan_pjsip and res_pjsip_t38, > causing them all to fail if Asterisk was compiled without pjproject. > > I have not looked into if these tests actually require res_pjsip_t38 (I don't > have pjproject on my system). I added it since all tests have 't38' in the > name. > > > Diffs > ----- > > /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml 5649 > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml 5649 > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml 5649 > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml > 5649 > > Diff: https://reviewboard.asterisk.org/r/4112/diff/ > > > Testing > ------- > > Verified these tests no longer attempt to run when Asterisk was compiled > without pjproject. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev