> On Oct. 30, 2014, 8:32 p.m., rmudgett wrote: > > /branches/11/funcs/func_jitterbuffer.c, lines 309-310 > > <https://reviewboard.asterisk.org/r/4128/diff/1/?file=68612#file68612line309> > > > > ast_frfree(frame) before dup replaces frame.
This caused a segmentation fault in tests/funcs/func_jitterbuffer. > On Oct. 30, 2014, 8:32 p.m., rmudgett wrote: > > /branches/11/funcs/func_jitterbuffer.c, line 315 > > <https://reviewboard.asterisk.org/r/4128/diff/1/?file=68612#file68612line315> > > > > ast_frfree(frame) before replacing with null frame. This caused a segmentation fault in tests/funcs/func_jitterbuffer. - Corey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/#review13639 ----------------------------------------------------------- On Oct. 30, 2014, 8:06 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4128/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 8:06 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22409 > https://issues.asterisk.org/jira/browse/ASTERISK-22409 > > > Repository: Asterisk > > > Description > ------- > > These changes are not controversial and fix a memory leak so they are now > split from r3603. > > In 12+ these changes apply to main/abstract_js.c instead of > funcs/func_jitterbuffer.c. > > > Diffs > ----- > > /branches/11/funcs/func_jitterbuffer.c 426593 > > Diff: https://reviewboard.asterisk.org/r/4128/diff/ > > > Testing > ------- > > tests/funcs/func_jitterbuffer against 13 no longer leaks. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
