----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review13685 -----------------------------------------------------------
Was the behavior for this ever brought up on the -dev list? I don't remember it so I don't think so. Before accepting the behavior you've done I'd really like us to talk about it there amongst everyone. I really think it's the reverse of what a user would expect to happen when a masquerade happens. - Joshua Colp On Oct. 31, 2014, 12:06 a.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3603/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 12:06 a.m.) > > > Review request for Asterisk Developers, Joshua Colp and Matt Jordan. > > > Bugs: ASTERISK-22409 > https://issues.asterisk.org/jira/browse/ASTERISK-22409 > > > Repository: Asterisk > > > Description > ------- > > During masquerade it is possible for the AST_JITTERBUFFER_FD to be cleared > (set to -1). This change adds a check when copying channel fd's to prevent > clearing an FD with -1. This seems to resolve the bad audio quality > experienced after the masquerade. When AST_JITTERBUFFER_FD was set to -1, > this prevented the channel from polling that timer. This caused RTP packets > to be received late, and discarded. > > > Diffs > ----- > > /branches/11/main/channel.c 426593 > /branches/11/funcs/func_jitterbuffer.c 426593 > > Diff: https://reviewboard.asterisk.org/r/3603/diff/ > > > Testing > ------- > > Verified the scenario outlined in ASTERISK-22409 no longer experiences audio > quality loss. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
